Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5566] - add configurable columns to document list #3473

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[ACS-5566] - add configurable columns to document list #3473

merged 1 commit into from
Oct 25, 2023

Conversation

dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
In document list component columns are static. Once configured via html or json, they can't be configured by end user

What is the new behaviour?
Document list component has possiblity to hide/show columns. Columns hidden by default have their property 'isHidden' both in component's inputs properties and in json. Maximum amount of visible columns is limited.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@MichalKinas MichalKinas force-pushed the ACS-5566-adf-configurable-document-list-layouts_1 branch from 903244e to ad1668d Compare October 25, 2023 12:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
85.7% 85.7% Duplication

@MichalKinas MichalKinas marked this pull request as ready for review October 25, 2023 13:05
@MichalKinas MichalKinas requested a review from eromano as a code owner October 25, 2023 13:05
@MichalKinas MichalKinas merged commit 835ddc3 into develop Oct 25, 2023
@MichalKinas MichalKinas deleted the ACS-5566-adf-configurable-document-list-layouts_1 branch October 25, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@MateuszHY MateuszHY MateuszHY approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@eromano eromano Awaiting requested review from eromano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dominikiwanekhyland @DenysVuika @MateuszHY @AleksanderSklorz @MichalKinas